JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Yun Jin's scalings don't seem correct #142

Open T3rraF0rm3r opened 2 years ago

T3rraF0rm3r commented 2 years ago

Describe the bug The normal attack bonus damage on Yun Jin's burst is treated as scaling with ATK instead of with DEF, and with her own Geo DMG Bonus, both of which are clearly not correct. It's also treated as scaling with her own Burst DMG Bonus and Crit stats, of which I don't know whether that is correct.

The optimizing function behaves accordingly, recommending Vortex Vanquisher, ATK Sands, Geo Cup, ATK Circlet, and Emblem as the set. Increasing Crit DMG via substats makes it correctly prefer Crit Rate over ATK on the Circlet.

To Reproduce Steps to reproduce the behavior:

  1. Select Bonus DMG as target
  2. Optimize everything Alternatively
  3. Try changing the named stats individually

Additional context Is there even any resource where one can look up the actual and precise details of how any skill in the game works?