search

JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Reaction Mode breaks artifact estimation #37

Closed SiriusGreyhound closed 3 years ago

SiriusGreyhound commented 3 years ago

https://youtu.be/7dXLcgr_xVM?t=1544

Turning on the reaction mode skews up the estimated improvement or downgrade and artifact has in the 'load artifact' screen. It seems like it doesn't update when reaction mode is toggled.

JenShin-368 commented 3 years ago

I was unable to replicate this bug. After watching the video a couple of times, it looks like the reaction mode prediction still updating. However, by saving/loading the optimizer target is reset to "Default" so it appears as if the reaction mode predictions were wrong b/c saving/loading changes the predictions. Can you confirm whether this is the case or not?

SiriusGreyhound commented 3 years ago

Before turning on reaction mode image

After turning on reaction mode image

As you can see in the second screenshot, when reaction mode is turned on the % values do not make sense anymore. The artifact that is worn should have 0%, since nothing changes when you put it on. So the information provided is not correct. Putting it on does not provide 26.32% improvement, it provides 0%, because it's the same artifact you already have on.

The only reason I've been loading the build is to try to get this to update. This happens as soon as you turn on reaction mode, loading the build has nothing to do with the bug.

But it isn't exactly the reaction mode that causes it. With reaction mode on, but no element selected in enemy calc the problem does not occur. But when an element is set in enemy calc it doesn't work.

There's something else I noticed. When I set up Diluc and use the enemy calc with hydro, the vaporize damage multiplier will be added to the damage without having to turn on the reaction mode. When I turn on reaction mode the damage gets improved even further. This must be the actual problem.

JenShin-368 commented 3 years ago

Fixed. It looks like the predictor wasn't caching the reaction proc chance.

As for the issue with Diluc, I'm not sure what the bug is there. If you can replicate it we should open another issue for it.