search

JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Bug on Load Build #52

Closed P2PSelfPuppet closed 3 years ago

P2PSelfPuppet commented 3 years ago

Describe the bug I saved a build named Xiao's Battery, the next day when I tried to load the build, it just won't load onto any slot. It also cannot be removed.

To Reproduce Steps to reproduce the behavior:

  1. Go to a character slot
  2. Click on 'load build'
  3. See error

Expected behavior You won't be able to load the build or even delete it, not even replaced it help.

Screenshots Screenshot (52)

As you can see, one of them cannot be removed and the other was created still.

Desktop (please complete the following information):

SiriusGreyhound commented 3 years ago

Hey there, thanks for reporting this. Maybe it's an issue with the name containing a symbol. Could you include a screenshot of your console as well so we can see if there's any error? I'll try to reproduce it for now.

Edit: Reproduced the issue with a build named "Razor's Battery". Issue is most likely related to the name.

P2PSelfPuppet commented 3 years ago

Screenshot (54)

Is this good enough?

SiriusGreyhound commented 3 years ago

My bad, the console is something you can open in your browser that shows console logs.

image

In Chrome you can use "Control + Shift + J" to open it directly.

P2PSelfPuppet commented 3 years ago

Screenshot (55)

This? Nothing happens with the log when I try to load Xiao's Battery, Xiao's Battery still won't load though, delete failed as usual.

SiriusGreyhound commented 3 years ago

Thank you. Now it's up to the developer to figure out what causes the problem. Too bad the console didn't yield any results.

JenShin-368 commented 3 years ago

Fixed. That name was supposed to be invalid but the regex was bugged.

I've implemented a catch that will resolve bugged names. Highly recommend deleting the build and renaming it to something that's valid.