JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Artifact Storage: Same name overrides previous artifact #61

Open SiriusGreyhound opened 3 years ago

SiriusGreyhound commented 3 years ago

The name of the artifact is currently required to be unique, but there is no prompt that warns you that you will override an existing artifact if you save one with the same name.

At least one person wants to be able to give two artifacts the same name.

Additional context Personally I don't know how important this is. I mean, it isn't hard to just use unique names. But it might be a little vexing if you don't know before hand and have to figure out why one of your artifacts disappeared.

It would be better practice to give artifacts a unique ID and the name is just flavor text that can be the same or whatever people want as well as a generic name being generated if people do not enter one.