JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

no artifacts are in storage: "No artifacts in your storage." #62

Open SiriusGreyhound opened 3 years ago

SiriusGreyhound commented 3 years ago

Some has pointed out that if there's no artifact saved in the category it just shows nothing. They pointed out that it could be clearer by giving you a text that tells you that you have no x-type of artifact in your storage.

image

Obviously this is only for clarity and doesn't make anything better or worse. Way I see it there's two options:

  1. Print out the "Show Loaded Artifacts" container with a text in stead of an artifact to clarify there are none:
+-----------------------------+
| Saved Goblet                |
|-----------------------------|
| No goblets in your storage. |
+-----------------------------+
  1. It doesn't open the "Show Loaded Artifacts" container and instead gives an error message:
    +-----------------------------+
    | No goblets in your storage! |
    +-----------------------------+

    The error message should just appear for a few seconds when the artifact icon is clicked. Additionally in the context menu when using right click the "Load Artifact" option should be greyed out.

Option 1 is probably easier to implement, while option 2 would be more elegent.