JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Weapon optimizer button will also display weapons that's ability off, #64

Open planktonfun opened 3 years ago

planktonfun commented 3 years ago

The weapon optimizer button, chooses from a list of weapons that's ability is on by default. this is good but if the user has no option(or condition) to use that ability there should be another available weapon for the user to choose

To fix this there should be more options where the optimizer choose from (No ability, maxed ability, ability option 1,2,3) in the list there's an instance where a weapon has no ability by default catalyst (The Widsth) where it should at least pick one to be used on the list Recitative, Aria, Interlude where each one gives different optimal value.

Here's a proposed solution: can be done by adding another loop in the code with weapon ability is off image