JenShin-368 / GenshinImpactCalculator

Genshin Impact Damage Calculator and Optimizer
26 stars 2 forks source link

Give user the means to compare two(or more) builds side-by-side #81

Open albertlaiuste opened 3 years ago

albertlaiuste commented 3 years ago

Describe the solution you'd like It would be nice to have a separate metric in the right side menu that shows how close your current character is to the maximum damage output of said character. One way this could be achieved is to have a template for each character with perfect artifacts and weapon for said character with maxed out level and talents and then compare your current active character to said template. This would be useful as it gives you a quick indicator of your current power level with said character and whether it is worth to pursue investing further into increasing their power or if to rather start investing into a different character.

Describe alternatives you've considered One issue this rises would be increased maintainability as sometimes new artifact sets get released and the best in slot artifact substat weights for different builds can also vary, such as burst Childe vs sustained Childe. Alternative to this could be to provide a dropdown menu with a selection of template the comparison is made with maybe relevant patch info, e.g. [Carry Klee, patch 1.5]. This way, even if it the template is outdated the user is aware of it and can make the judgement call themselves of how much they would rely on provided information.

Another alternative would be to simply give user the means to compare two(or more) builds side-by-side with maybe additional values displayed in percentages of the difference between the metrics. This way, users can themselves define what the perfect build might be, which comes at no increased cost of maintainability, utilizes the already existing builds system and adds more incentive to purchase premium for extra build and artifact slots. The disadvantage of this approach would be that first the users need to be aware of said feature and as it requires extra setup and active input from their end it might end up not being used too frequently.

Additional context Ultimately, this would simply be a nice feature to have but I can completely see how this feature might be way more effort than it is worth. Just tossing the idea here as this is something that I've thought of multiple times whenever I'm using the calc, going as far as to have separate artifacts in Artifact Storage with perfect stats to simply see how far my current ones are from it to gain a rough estimation of proposed metric.

A screenshot to roughly illustrate the idea: image

JenShin-368 commented 3 years ago

"Another alternative would be to simply give user the means to compare two(or more) builds side-by-side with maybe additional values displayed in percentages of the difference between the metrics. This way, users can themselves define what the perfect build might be"

I like that idea because build comparison features will be useful in ways other than just a comparison of an ideal "max build". Max builds are also dependent on various factors (i.e. one build could focus on physical damage, another on elemental, another on elemental skill, etc.).