Jenesius / vue-modal

🖖The progressive and simple modal system for Vue.js v3
https://modal.jenesius.com
MIT License
150 stars 14 forks source link

JenesiuVueModal + VueRouter #20

Closed Jenesius closed 3 years ago

Jenesius commented 3 years ago

Need add integration with VueRouter

Jenesius commented 3 years ago

Main problem: route A, route B, route M(where modal we open the modal)


We add rules: M.onclose = () => back(); Its working, when we do closeModal() or popModal() NEAD ADD GUARD afterModalClose But if we put button back in browser we leave twice, first time, because default back, the second time when closing the modal window

Jenesius commented 3 years ago

Component binding only once Need initialize props: _isNavigationClosingGuard and other

Jenesius commented 3 years ago

There is a problems in realization: ModalRouterObject is a object, not function So, need a way to save data(IsNavigationGuard), but for the same router - same store If we go A, then go ModalB -> set some value -> go A -> gotModalB -> values was the same

Jenesius commented 3 years ago

Creating shadow vue-router is necessary. Okay. is ready, writing test and think how add vue-router to rollup

Jenesius commented 3 years ago

test is ready Thinking about names of methods

Jenesius commented 3 years ago

Russian documentation is ready