Open Jenncscampbell opened 6 years ago
Hey @Jenncscampbell,
I thought you did a really great job with your homework 4 - here are some comments:
Excellent work overall!
Cheers, Victoria
Hi Jenn,
Nice job on your homework! A few comments on the first part:
gapminder %>%
group_by(continent,year) %>%
summarize(Mean_lifeExp=mean(lifeExp)) %>%
ggplot(aes(x=year,y=Mean_lifeExp,color=continent))+geom_point()
And a couple comments on the second part:
Again, nice work! Good luck with the rest of your assignments! Best, Rainer
@vmichalowski Thank you so much for your feedback! I didn't even notice the error with numbering
To my TAs: on my .Rmd file you can see that my original numbering was just 1. 2. 3. This was reformatted after knitr to be all 1. I experimented a bit and found that if I title the items (e.g., #1.) then it was fine. Why doesn't my original way work? Any insight here would be appreciated. Thank you!
Hi @jenncscampbell, here are some comments about your hw04:
Your grade will be emailed to you at a later date.
Edit: It looks like your reviewers were able to see your plots and that you made changes after submission which may have caused your plots to disappear. I saw your plots in one of the subfolders, but try to make sure they still show up in your markdown document next time!
Hi @derekcho
Sorry for the changes to the repo after the assignment! I started renaming the folders and organization things for hw 5 and things got a bit messy.
I just tried now to knit the doc and see if the graphs show and they show now. I don't really remember what I did yesterday but do you think it was that I forgot to knit it first? Is that the step that creates the .png files for the plots?
Thanks for the feedback!!
Jenn
Hi @Jenncscampbell
If I had to guess, I would say that it was because you changed the names of the folder that everything was stored in from hw04_files to hw04. GitHub probably didn't know where to look for the figures so it omitted them altogether. Notice that you have a new folder with the same figures called hw04_files now? You should have a similarly named folder in each of your homework folders which also have plots inside.
Cheers,
Derek
@rainerlempert @vmichalowski