search

Jennifer-Hinrichsen / emotion-tracker

https://emotion-tracker-theta.vercel.app
2 stars 1 forks source link

Feature/filter emotion entries #30

Closed W-Schkulov closed 3 weeks ago

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emotion-tracker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 9:49am
StephieTack commented 3 weeks ago

Hello team, 👋

I have written a few comments for you. Several (three?) comments concern semantic HTML - you should make sure that you use semantic HTML and apply it correctly.

Otherwise your filter works well, so well done. 😊

However, you have not met all of the acceptance criteria from the US: → "Users can clear all filters with a single click, returning the list to its unfiltered state." So you have to improve this again, I'm sorry. 🤷‍♀️

Have fun coding anyway! 😊

Hi Elisabeth, you can clear the filter when you click on the chosen filter once again. :) Thank you for your PR and your detailed informations. :)