search

JenniferBuehler / gazebo-pkgs

A collection of tools and plugins for Gazebo
BSD 3-Clause "New" or "Revised" License
207 stars 104 forks source link

Added ContactManager filter release instruction for safe plugin reloa… #34

Closed e-fominov closed 5 years ago

e-fominov commented 5 years ago

I have found that I can't spawn/delete same model multiple times with GrastFix plugin is loaded. After model deletion, I am trying to load it again, but having an error message:

[Err] [ContactManager.cc:360] Filter with the same name already exists! Aborting

This PR introduces a fix that will make plugin remove the ContactManager filter in destructor allowing us to spawn same model again.

JenniferBuehler commented 5 years ago

Hello, thank you for your contribution! This looks good to me upon first glance, but I'd like to try it out myself. Not sure when I'll have the time to do this, until then I hope you're fine using your fork. Before I do any other updates to this repo, I'll be sure to handle this PR, so you won't have to merge with upstream again.

JenniferBuehler commented 5 years ago

Thanks again for your contribution!