search

Jense5 / electron-ad-blocker

Blocks advertisements in an electron browser window
Mozilla Public License 2.0
53 stars 8 forks source link

Can't install module with electron 2.0.0 and node 8.9.3 on Travis CI #5

Open PaulRBerg opened 6 years ago

PaulRBerg commented 6 years ago

I checked out the other issues and read your article.

I get the same #include "BloomFilter.h" error as in #3. I made sure that I have the right version of electron and node. Here's the log.

nhandt64 commented 6 years ago

Yeah, I have same error like you, although I installed with yarn too.

ErraticFox commented 5 years ago

This package relies on another package called contains-ads which is also maintained by the beautiful @Jense5 as well. The contains-ads package relies on another package, ad-block by Brave Browser. The ad-block package version was depreciated which caused this build error. I've submitted a PR to contains-ads bumping the ad-block package version and fixing the build error. I cannot do a PR for this package until the PR from contains-ads is accepted as it relies on that package. So if you want, you guys can use this forked repo until it's fixed though once it does get fixed, you should definitely switch back.

Jense5 commented 5 years ago

Hey guys, sorry for the late reply. I don't have much time right now but will try to fix this in the upcoming weekend.

RedSparr0w commented 5 years ago

Any updates on this?

I've tried using the forked repo but that doesn't seem to work for me either.

remusao commented 4 years ago

@RedSparr0w maybe this other comment of mine would be useful to you as well: https://github.com/Jense5/electron-ad-blocker/issues/8#issuecomment-523567298