search

Jense5 / electron-ad-blocker

Blocks advertisements in an electron browser window
Mozilla Public License 2.0
53 stars 8 forks source link

Deprecated since electron 4.x? #9

Open sier opened 4 years ago

sier commented 4 years ago

Trying to implement this in Electron 4.0.1 (Running node 10.16.1 LTS) I get the follow error:

/Users/sier/.node-gyp/10.16.1/include/node/v8config.h:327:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
2 warnings and 1 error generated.
make: *** [Release/obj.target/hashset-cpp/HashSetWrap.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/sier/.nvm/versions/node/v10.16.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/Users/sier/.nvm/versions/node/v10.16.1/bin/node" "/Users/sier/.nvm/versions/node/v10.16.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/sier/Documents/Github/{my_github_repo}/node_modules/hashset-cpp
gyp ERR! node -v v10.16.1
gyp ERR! node-gyp -v v3.8.0

Am I doing something wrong or is this not updated for later node and electron versions?

remusao commented 4 years ago

Hi @sier,

If you're looking for an up-to-date adblocker to use in Electron, I have recently released one which is actively developed and maintained; feel free to have a look: https://github.com/cliqz-oss/adblocker/tree/master/packages/adblocker-electron#usage

Also, since it's pure-JavaScript, there is no build step at all so it should be simpler to integrate in your project.

Cheers,