search

JensonWee / pe

0 stars 0 forks source link

Delete Patient error message inaccurate #1

Open JensonWee opened 4 years ago

JensonWee commented 4 years ago

Description: "deletep" function seems to have inaccurate error message. It indicates :" Please input a valid integer that is within range of the list as the index for the command deletep".

Steps: 1) Add a patient using "addp \name John \ 2) "deletep" 3) "deletep " 4) "deletep " 5) "deletep /" 6) "deletep /i" 7) "deletep /index" 8) "deletep /index " 9) "deletep 1"

image.png

image.png

nus-pe-bot commented 4 years ago

Team's Response

Rejected as this is the intended behaviour as documented in UG

Rejected Justification:

Section 4.1.3 of the UG explains the usage of deletep. The correct format should be \index exactly. In addition, this is compulsory.

Section 3 of the UG explains that all dummy fields will be ignore. That is to say, any typing errors for \index will be considered as dummy fields and ignored by HAMS.

Because deletep expects an index, if no index format \index is correctly given, it will print this message.

image.png

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As what I've state in the response, it is indeed an inaccurate error message. Despite what your UG states, the error message used does not accurately describe the problem.