search

JensonWee / pe

0 stars 0 forks source link

Adding patient allow null or whitespace as name #4

Open JensonWee opened 4 years ago

JensonWee commented 4 years ago

Description: No error message for fields empty for adding patient, allowing empty spaces. Indicated in the UG that field will be ignored, however, may be showing error message would aid the user better?

Steps: 1) "addp \name \age 4 \address a \phone 12345677" 2) "addp \name \age \address a \phone 12345677" 3) "addp \name \age \address \phone 12345677" 4) "addp \name \age 10 \address \phone"

image.png

nus-pe-bot commented 4 years ago

Team's Response

Not a bug as it is documented in the UG. This is the actual behaviour.

Rejected justification:

Section 4.1.1 of the UG explains the addp functionality.

In this section, it is stated that at least 1 format must be provided. According to the 4 inputs of the bug report, at least 1 correct format has been provided.

It is also stated that if a format is provided but no value is given, then HAMS will ignore it.

Because at least 1 correct format was given, no error message will be printed.

image.png

image.png

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It is true that your UG state that it will be ignored. However, I disagree that this bug is rejected as it shouldn't be allowed to add a patient without a name. Perhaps an error should be showed at least.