search

JenspederM / kedro-databricks

A Databricks Plugin for Kedro
MIT License
10 stars 4 forks source link

Open up the support for Python>=3.9 to align with Kedro 0.19 #27

Closed noklam closed 1 month ago

noklam commented 1 month ago

Is there a specific reason why this only support Python 3.11+? It looks like it can support 3.9+ that aligns with Kedro 0.19+

JenspederM commented 1 month ago

@noklam I've had some issues getting the test suite up and running on github with lower versions..

You're welcome to give it a go :)

noklam commented 1 month ago

ERROR: Ignored the following yanked versions: 7.1.0, 7.30.0, 8.13.0, 8.16.0, 8.17.0 ERROR: Ignored the following versions that require a different python version: 8.19.0 Requires-Python >=3.10; 8.20.0 Requires-Python >=3.10; 8.21.0 Requires-Python >=3.10; 8.22.0 Requires-Python >=3.10; 8.22.1 Requires-Python >=3.10; 8.22.2 Requires-Python >=3.10; 8.23.0 Requires-Python >=3.10; 8.24.0 Requires-Python >=3.10; 8.25.0 Requires-Python >=3.10; 8.26.0 Requires-Python >=3.10 ERROR: Could not find a version that satisfies the requirement ipython==8.26.0 (from versions: 0.10, 0.10.1, 0.10.2, 0.11, 0.12, 0.12.1, 0.13, 0.13.1, 0.13.2, 1.0.0, 1.1.0, 1.2.0, 1.2.1, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.3.1, 2.4.0, 2.4.1, 3.0.0, 3.1.0, 3.2.0, 3.2.1, 3.2.2, 3.2.3, 4.0.0b1, 4.0.0, 4.0.1, 4.0.2, 4.0.3, 4.1.0rc1, 4.1.0rc2, 4.1.0, 4.1.1, 4.1.2, 4.2.0, 4.2.1, 5.0.0b1, 5.0.0b2, 5.0.0b3, 5.0.0b4, 5.0.0rc1, 5.0.0, 5.1.0, 5.2.0, 5.2.1, 5.2.2, 5.3.0, 5.4.0, 5.4.1, 5.5.0, 5.6.0, 5.7.0, 5.8.0, 5.9.0, 5.10.0, 6.0.0rc1, 6.0.0, 6.1.0, 6.2.0, 6.2.1, 6.3.0, 6.3.1, 6.4.0, 6.5.0, 7.0.0b1, 7.0.0rc1, 7.0.0, 7.0.1, 7.1.1, 7.2.0, 7.3.0, 7.4.0, 7.5.0, 7.6.0, 7.6.1, 7.7.0, 7.8.0, 7.9.0, 7.10.0, 7.10.1, 7.10.2, 7.11.0, 7.11.1, 7.12.0, 7.13.0, 7.14.0, 7.15.0, 7.16.0, 7.16.1, 7.16.2, 7.16.3, 7.17.0, 7.18.0, 7.18.1, 7.19.0, 7.20.0, 7.21.0, 7.22.0, 7.23.0, 7.23.1, 7.24.0, 7.24.1, 7.25.0, 7.26.0, 7.27.0, 7.28.0, 7.29.0, 7.30.1, 7.31.0, 7.31.1, 7.32.0, 7.33.0, 7.34.0, 8.0.0a1, 8.0.0b1, 8.0.0rc1, 8.0.0, 8.0.1, 8.1.0, 8.1.1, 8.2. ERROR: No matching distribution found for ipython==8.26.0

@JenspederM Why do you pin ipython to 8.26.0?

https://pypi.org/project/ipython/, this is the latest version and thus doens't exist in older version. Is it possible to set a lower bound or remove it altogether?

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 5e4dd148 and detected 0 issues on this pull request.

View more on Code Climate.

noklam commented 1 month ago

I am not familar with rye, but seems that during the installation step it force the installation follow either requirements.txt or requirements-dev.lock? These requirements are too restricted as a library, it should only be pinned on the application side.

JenspederM commented 1 month ago

I have been a bit lazy with the type system, so I didn't support <3.11.

I have made the necessary changes in #29 🙂