search

JenspederM / kedro-databricks

A Databricks Plugin for Kedro
MIT License
13 stars 5 forks source link

feat(deploy): add a target cli option to deploy #41

Closed npfp closed 2 months ago

npfp commented 3 months ago

Add target cli option to give the user the ability to choose the databricks target environment independently from the kedro environment.

If not set, defaults to the previous behaviour by using the env value.

npfp commented 3 months ago

This is really just a proposition. Feel free to modify/refuse the implementation if it doesn't fit into the plugin logic.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (45736ea) to head (318c2df). Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #41 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 350 350 ========================================= Hits 350 350 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JenspederM commented 2 months ago

@npfp Just need a signed commit, then this is good to go

JenspederM commented 2 months ago

FYI, to help myself with this I have registered this alias in my .zshconfig: alias gcasm='git commit --all --signoff --message'

npfp commented 2 months ago

Thx!

JenspederM commented 2 months ago

@npfp I'm sorry. You were right, there were unverified commits in the main branch which blocked. Switched to a new computer today, so i hadn't configured my own system properly

To fix it, I had to do a force push which altered the history and again, requires you to rebase against main.

Everything should be good now, though. Sorry for the inconvenience.

npfp commented 2 months ago

Ok, I finally fixed the new history of the 2 PRs.

JenspederM commented 2 months ago

I'm sorrry about this, but your commits are still not verified. You can set it up using this guide: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification :)

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit 318c2dfa and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.