search

JeongJun-Lee / ionic5-star-rating

17 stars 25 forks source link

Stars are not showing up #2

Open saurabhshrivastava2111 opened 3 years ago

saurabhshrivastava2111 commented 3 years ago

It seems the button is used instead of an ion-button. Can we have the fix for this?

JeongJun-Lee commented 3 years ago

Hello, could you give me a PR for that?

ahmad-alk commented 3 years ago

Same here, any suggestions ?

arkarwin510 commented 3 years ago

ios-star and ios-star-outline don't support in ionic 5. It should modify supported name in activeIcon and defaultIcon. (eg. <ionic5-star-rating #rating activeIcon = "star" defaultIcon = "star-outline" activeColor = "#488aff" defaultColor = "#f4f4f4" readonly="false" rating="3" fontSize = "32px" (ratingChanged)="logRatingChange($event)">

)