search

Jeonhui / FittedSheets-SwiftUI

Fitted Sheets for SwiftUI
MIT License
16 stars 6 forks source link

Sheet Height Change #3

Closed metallica1375 closed 3 weeks ago

metallica1375 commented 4 months ago

Hey, When the height of content of the sheet changes, the sheet's height won't change. Imagine That I have a segmented button in my sheet that handles 3 different pages that shows in the sheet and the height of those pages differs. in this situation I have problem with auto increase or decrease the height of the sheet

Jeonhui commented 4 months ago

I will check this and fix it ASAP, thank you for notifying me know about this. Additionally, I will update Example App, after fix this issue. :)

Jeonhui commented 4 months ago

I fixed it like below. I will distribute this version ASAP. Please wait some days. thx. Simulator Screen Recording - iPhone 15 Pro - 2024-05-18 at 21 55 47

Jeonhui commented 4 months ago

I fixed this issue and distributed v1.2.0, can you check it?🙃

metallica1375 commented 4 months ago

Thanks buddy! I'ma check it soon

metallica1375 commented 4 months ago

I tested it and it worked just fine, thanks man. is there any option to prevent the sheet's root page to collapse a bit? I want to have the inline mode behavior in the non-inline content

Jeonhui commented 4 months ago

Thx bro. Can i check the detailed code?

pensacola1989 commented 3 months ago

can I remove the little pull bar？

pensacola1989 commented 3 months ago

can I remove the little pull bar？

just set the height to zero？

Jeonhui commented 3 months ago

@pensacola1989 If you set the option to .init(pullBarHeight: .zero), you can see the image below.

스크린샷 2024-06-10 00 35 27

This library is depended on FittedSheets and has implemented almost all of the features of FittedSheets for use in SwiftUI. So I can't fix the UIViewController on FittedSheets. But I'll implement the Hide Pull Bar option if you need it or want it. (This code will not be much different from setting to pullBarHeight zero)

pensacola1989 commented 3 months ago

thx

发自我的iPhone

------------------ Original ------------------ From: Jeonhui Lee @.> Date: Sun, Jun 9, 2024 11:46 PM To: Jeonhui/FittedSheets-SwiftUI @.> Cc: ddw @.>, Comment @.> Subject: Re: [Jeonhui/FittedSheets-SwiftUI] Sheet Height Change (Issue #3)

pensacola1989 commented 3 months ago

there is another issue that the container which hold the whole sreen in back is not round corner。any way to make it round？

发自我的iPhone

------------------ Original ------------------ From: Jeonhui Lee @.> Date: Sun, Jun 9, 2024 11:46 PM To: Jeonhui/FittedSheets-SwiftUI @.> Cc: ddw @.>, Comment @.> Subject: Re: [Jeonhui/FittedSheets-SwiftUI] Sheet Height Change (Issue #3)

pensacola1989 commented 3 months ago
image

I download FiteedSheet demo,it has rounded corner in background,and your wrapper of SwiftUI,screen shot blew:

image