JerBouma / FinanceToolkit

Transparent and Efficient Financial Analysis
https://www.jeroenbouma.com/projects/financetoolkit
MIT License
2.96k stars 355 forks source link

Implementation of Filing date and experimental quarterly filings #45

Closed sword134 closed 1 year ago

sword134 commented 1 year ago

For testing purposes only. This version will not work as intended for quarterly API requests

JerBouma commented 1 year ago

Thanks for the PR, I've worked on some fixes to the code so that it is possible to correctly get the data. Please let me know if this works! See related files:

JerBouma commented 1 year ago

This might also fix #44. Can you test for that?

sword134 commented 1 year ago

I've commited some changed to saving the filing date. It only works for the get_income_statement() function for now. But is easily copy pasted onto balance and cash flow if approved.

JerBouma commented 1 year ago

My thinking is to create a separate function that creates a DataFrame including Cid ID, Filing Date etc (general statistics)

This function uses the same API call as for each financial statement and automatically collects and saves that data as well so that you don't need two API Calls.

Let's do that separately from this PR, therefore I'd recommend reverting the change to add filing date.

sword134 commented 1 year ago

My thinking is to create a separate function that creates a DataFrame including Cid ID, Filing Date etc (general statistics)

This function uses the same API call as for each financial statement and automatically collects and saves that data as well so that you don't need two API Calls.

Let's do that separately from this PR, therefore I'd recommend reverting the change to add filing date.

Ok. The commit you made works for the intended purposes of quarterly statements. The only addition I have for that is the minor change in balance.csv where there is a empty duplicate of Minority Interest (,Minority Interest)

JerBouma commented 1 year ago

Great, please reverse the filling dates code and then I can merge it in. After creating a separate function for the statistics data we can create a new version.

sword134 commented 1 year ago

@JerBouma alright, i've reverted the changes. Only balance.csv has been changed from this commit from my side since yesterday