search

JerBouma / FinanceToolkit

Transparent and Efficient Financial Analysis
https://www.jeroenbouma.com/projects/financetoolkit
MIT License
2.84k stars 347 forks source link

[IMPROVE]List of all the available names that can be used in a custom ratio #90

Closed giraffeingreen closed 9 months ago

giraffeingreen commented 9 months ago

What's the feature that should be improved?

All the valid names that can be used in a custom ratio.

Describe how you would like the feature improved Include a list of all the valid names that can be used in a custom ratio.

Possibly describe the ideal way to improve this Using pandas should be easy to get the column names.

Additional information At this point in the code you already have all the data available. https://github.com/JerBouma/FinanceToolkit/blob/82550930d55bd0f63611e7750201735edaaab692/financetoolkit/ratios/ratios_controller.py#L299

JerBouma commented 9 months ago

Are you feeding the custom ratios into the Toolkit initialization or directly in the custom ratios function? I can indeed quite easily add it in for the latter!

JerBouma commented 9 months ago

Will do a release early this year with this functionality, already have it available on the develop branch.

image
giraffeingreen commented 9 months ago

That's exactly what I was excepting! Thank you!

JerBouma commented 9 months ago

Fixed in v1.7.3 👍

https://github.com/JerBouma/FinanceToolkit/releases/tag/v1.7.3