search

Jerakin / Pokedex5E

GNU General Public License v3.0
95 stars 30 forks source link

Feature/581 more pokemon variants #623

Closed magroader closed 4 years ago

magroader commented 4 years ago

Fixes #581

Currently this code only allows changing the Pokemon variant from the Edit menu. It does not allow on-the-fly changes from the regular party screen. I'm not sure how necessary that is.

This also allows you to change the size of Pumpkaboo / Gourgeist. This could be adjusted - I have data that comes through to variant_data like permanent (true/false). I also have create_mode (currently "choose" or "default"), the idea being whether you choose the form when the pokemon is first created or not... but this doesn't seem to be especially necessary because of the variant selector on the edit/add screen. As an example, Rotom has create_mode "choose" because you could find a Rotom lawnmower in the wild, but Giratina starts in "Altered Forme" and Hoopa starts in "Confined" so their create_mode are both set to "default".

This aligns with p5e_data_conversion PR https://github.com/Jerakin/p5e-data-conversion/pull/2

magroader commented 4 years ago

One good way to test this out would be to switch to the current release branch, add a bunch of pokemon with and without variants, back up save folder (the whole folder, really - both the profile and also the overall data gets adjusted to adjust the profile slot pokemon species/variant names for the profile screen), switch to the new version, and make sure everything works. I did test this out, but it's always possible I broke something since the last time I tested that.

Of special note: Zygarde Complete Form/Forme has a weird name and had a bug at first, could use another test with that pokemon in the party before switching to this branch to test.