Jerakin / Pokedex5E

GNU General Public License v3.0
94 stars 30 forks source link

pokemon.get_skills_modifier does not account for Expertise #755

Open magroader opened 3 years ago

magroader commented 3 years ago

If a Pokemon has a skill proficiency, and also takes a feat to grant that skill proficiency (Brawny, Perceptive, Acrobat, Quick-Fingered, Stealthy), the pokemon.get_skills function returns the skill with a " (e)" suffix.

This results in a skill that is not really a skill, and the current 1.13.9 version of the app crashes on this.

I have fixed the crash by ignoring skills that aren't "real", but the latest version of the code still has a problem - it will not show the skill modifier for this, e.g.:

In addition, tapping on the skills list will undoubtedly show the wrong value.

Finally, pokemon like Arceus who are skilled in "All Skills" will not show expertise at all if they have such feats.