JeremiasLiew / pe

0 stars 0 forks source link

Wrong exception thrown when editing info wrongly #4

Open JeremiasLiew opened 4 years ago

JeremiasLiew commented 4 years ago

Wrong exception thrown when trying to edit patient's phone number to an invalid number. In this case, the phone number should be invalid because it does not start with 8/9, and not because it does not have 8 digits.

image.png

nus-pe-bot commented 4 years ago

Team's Response

The error message is intended (to notify the user of incorrect phone number) but we will take note of the confusion casued to the user, will improve on it and ensure accurate error message is printed.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: I might be mistaken here, but isnt a Documentation Bug only for bugs in documentation, as the name suggests? Documentation would include the UG and DG in this case.

Throwing the wrong exception does not seem like it has anything to do with the UG or the DG.