search

JeremiasLiew / pe

0 stars 0 forks source link

Unable to get patients #6

Open JeremiasLiew opened 4 years ago

JeremiasLiew commented 4 years ago

As can be seen from the list patient command, I have 2 patients with NRIC as S1234567A and S7654321A respectively. However, I am unable to get patient them as they are considered invalid NRICs.

image.png

nus-pe-bot commented 4 years ago

Team's Response

Thanks for the feedback, we noted that error later on as well, we push the relevant changes in the next release. However, the issues is downgraded to medium as this single functionality has not caused the application to crash, and it is does not affect the use of the other features in the program.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: This bug should definitely have a severity of "severity.High", and NOT "severity.Medium". Just because it does not cause the app to crash is not a good enough reason to downgrade it to Medium severity.

This app is meant for doctors to store and manage patient records. If a doctor uses this app, apart from adding in new patients, he NEEDS to be able to view patient details as well. If not, then then what is the point of this app if it can only store patient general info but the doctor is unable to view it.

Yes, the team might want to argue that the find pr command to view past medical records still works. But if you look at the past medical records output, it only shows NRIC, and the Symptom+Diagnosis+Date&Time of the selected diagnosis report. It does NOT show important patient information such as date of birth, blood type, allergies or other important remarks, which can only be accessed using the get patient command that doesn't work. It cannot be accessed any other way.

If you were to ask any doctor for their opinion on this, they would say that for any consultations or even any diagnosis, any responsible doctor needs to know these vital information such as date of birth, blood type, allergies etc. As such, I would argue that with this get patient feature being impossible to use (not even faulty, there is literally no way to get this command to work), the app loses all meaning as the doctor is unable to use this app at all.

To cover all bases here, another possible argument that the team could make is that the doctor could just ask the patient for these important information. But I would counter that this is not always the case. Firstly, at that point, the app is already made useless because the doctor has to find out all these information again. Secondly, what if the patient is not able to remember/not able to respond (e.g. someone with a really high fever and cant remember, or an old patient who doesnt remember his allergies/blood type etc.). Maybe this does not represent the majority of patients, but doctors will definitely run into those cases, and they cannot risk using an app that doesnt work during these situations, which is why they cannot use this app.

Going back to the definiton of a "severity.High" bug on the CS2113 website, it can be broken down into 2 main parts :

1) "A flaw that affects most users..." As mentioned in their UG and the User Stories section of the DG, the users are meant to be doctors. As mentioned above, this will affect all responsible doctors, which we can reasonably assume will make up most of the doctors.

2) "...and causes major problems for users. i.e., makes the product almost unusable for most users." As mentioned above, doctors are almost completely unable to use this app because of this feature that is not working at all.