search

JeremyCCHsu / Python-Wrapper-for-World-Vocoder

A Python wrapper for the high-quality vocoder "World"
MIT License
724 stars 122 forks source link

```numpy < 1.20``` breaks p3.10 compatibility #70

Closed erogol closed 2 years ago

erogol commented 2 years ago

Loosening numpy < 1.20 requirements can fix the problem if don't cause something else.

https://github.com/JeremyCCHsu/Python-Wrapper-for-World-Vocoder/blob/cb69e0198be58e5bd68617062589dc131d56a6d7/pyproject.toml#L6

zstanecic commented 2 years ago

Hi, I will provide a patch soon, so that pyworld can be build with python 3.10 and downwards, too.

zstanecic commented 2 years ago

This will get fixed for all platforms when my PR gets merged. This relies on latest cython, numpy and scipy. We no longer restrict ourselves to the particular package versions, but we choose the package chosen by pip automatically.

JeremyCCHsu commented 2 years ago

thx @zstanecic.

zstanecic commented 2 years ago

Can you please release this into pip?

From: Jeremy Hsu @.> Sent: Friday, August 19, 2022 9:32 AM To: JeremyCCHsu/Python-Wrapper-for-World-Vocoder @.> Cc: Zvonimir Stanečić @.>; Mention @.> Subject: Re: [JeremyCCHsu/Python-Wrapper-for-World-Vocoder] numpy < 1.20 breaks p3.10 compatibility (Issue #70)

thx @zstanecic https://github.com/zstanecic .

— Reply to this email directly, view it on GitHub https://github.com/JeremyCCHsu/Python-Wrapper-for-World-Vocoder/issues/70#issuecomment-1220176538 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDE5YXQ6H26ITLBLIAMTVZ3W23ANCNFSM5VUSKRXA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ACVCDE6JYER3EFBU5VX4GTDVZ3W23A5CNFSM5VUSKRXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJC5GVGQ.gif Message ID: @. @.> >