search

JeremyCCHsu / Python-Wrapper-for-World-Vocoder

A Python wrapper for the high-quality vocoder "World"
MIT License
724 stars 122 forks source link

Updated world vocoder, bumped pyworld to v 0.3.2 #80

Closed zstanecic closed 2 years ago

zstanecic commented 2 years ago

Tested this thoroughly, as i use Pyworld in the RHVoice project. I see that it fixes

58

This pull request updates the pyworld to be synced from the latest version from february this year.

JeremyCCHsu commented 2 years ago

Thank you. I'll update the artifacts for PyPI later.

zstanecic commented 2 years ago

Btw, please fix these artifacts, because pyworld is not distributed into tarballs.

This fails compiling when on pipi.

From: Jeremy Hsu @.> Sent: Tuesday, November 1, 2022 2:56 PM To: JeremyCCHsu/Python-Wrapper-for-World-Vocoder @.> Cc: Zvonimir Stanečić @.>; Author @.> Subject: Re: [JeremyCCHsu/Python-Wrapper-for-World-Vocoder] Updated world vocoder, bumped pyworld to v 0.3.2 (PR #80)

Thank you. I'll update the artifacts for PyPI later.

— Reply to this email directly, view it on GitHub https://github.com/JeremyCCHsu/Python-Wrapper-for-World-Vocoder/pull/80#issuecomment-1298547811 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDE3JLCUGWFXVHTV3J2DWGEOPZANCNFSM6AAAAAARR4A4SU . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ACVCDEY5INCEUWVU3YSFGADWGEOPZA5CNFSM6AAAAAARR4A4SWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSNMZCGG.gif Message ID: @. @.> >

JeremyCCHsu commented 2 years ago

The artifacts are uploaded to PyPI now. Let me know if I missed anything.

r9y9 commented 2 years ago

Is this just speed improvement? Or does it have any impact on the output of speech parameters? I wonder if the new version is compatible with older versions.

zstanecic commented 2 years ago

New version is compatible with old ones, too.

They made fixes to the codebase and gave the comments in the code.

From: Ryuichi Yamamoto @.> Sent: Wednesday, November 2, 2022 9:53 AM To: JeremyCCHsu/Python-Wrapper-for-World-Vocoder @.> Cc: Zvonimir Stanečić @.>; Author @.> Subject: Re: [JeremyCCHsu/Python-Wrapper-for-World-Vocoder] Updated world vocoder, bumped pyworld to v 0.3.2 (PR #80)

Is this just speed improvement? Or does it have any impact on the output of speech parameters? I wonder if the new version is compatible with older versions.

— Reply to this email directly, view it on GitHub https://github.com/JeremyCCHsu/Python-Wrapper-for-World-Vocoder/pull/80#issuecomment-1299868976 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVCDEZTFTUWTK3CJ75DK4LWGITWLANCNFSM6AAAAAARR4A4SU . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ACVCDE7YFATFBWJECYRUXHLWGITWLA5CNFSM6AAAAAARR4A4SWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSNPJWTA.gif Message ID: @. @.> >

r9y9 commented 2 years ago

Thanks for the explanation! I understood.