search

JeremyDunn / php-fedex-api-wrapper

This library provides a fluid interface for constructing requests to the FedEx web service API.
269 stars 184 forks source link

src/FedEx/OpenShipService/SimpleType/ServiceType.php no longer exists #200

Closed brandonjbegle closed 2 years ago

brandonjbegle commented 2 years ago

After commit c5385da073cdcba26cf730a7688c952404b6241f 4 days ago:

src/FedEx/OpenShipService/SimpleType/ServiceType.php src/FedEx/OpenShipService/SimpleType/PackagingType.php

no longer exist on the repository.

Is there a reason for this change?

Screen Shot 2022-02-18 at 3 57 58 PM
JeremyDunn commented 2 years ago

@brandonjbegle

Hi from Evansville 👋

It's because the OpenshipService_v20.wsdl no longer has this type defined and that class should have been deleted when the code was regenerated after updating from v15 to v20. I think I may update the script that generates this code to delete files first so it's obvious to anyone updating a wsdl and generating code that some files should be removed from the repo.

https://github.com/JeremyDunn/php-fedex-api-wrapper/pull/187/files#diff-df094db12113424dfc8bdbe7866e63f1adf2d8a30031737d2510bf4891515b57L5634

Update_services__tests__examples_and_composer_packages_by_mixisLv_·_Pull_Request__187_·_JeremyDunn_php-fedex-api-wrapper
brandonjbegle commented 2 years ago

Thanks for the response. I ended up seeing that change and we decided to just revert to 6.0.1 so we didn't have to make any changes.