JeremyEnglert / JointsWP

A blank WordPress theme built with Foundation 6, giving you all the power and flexibility you need to build complex, mobile friendly websites without having to start from scratch.
http://jointswp.com
853 stars 272 forks source link

Smooth Scrolling Error (with Magellan) fix suggested #298

Closed leadbellydesign closed 6 years ago

leadbellydesign commented 6 years ago

Uncaught TypeError: Cannot read property 'scrollToLoc' of undefined

I ran across this error when trying to implement smooth scrolling with magellan. After some research, I came across this issue on Github: Foundation 6.4: Drop-in compiled JS files in dist/js -> Uncaught TypeError: Cannot read property 'scrollToLoc' of undefined #10502

When going into gulp.js and moving the load order of scripts, as suggested (smoothScroll before magellan), the problem was solved.

Thought I'd let you know so you can update the load order in the repo.

garretthyder commented 6 years ago

Thanks @leadbellydesign I've submitted a PR to resolve this issue.