search

JeremyEnglert / JointsWP

A blank WordPress theme built with Foundation 6, giving you all the power and flexibility you need to build complex, mobile friendly websites without having to start from scratch.
http://jointswp.com
851 stars 272 forks source link

Use gulp from npm repository to make it work without git dependency #412

Open mziab opened 4 years ago

mziab commented 4 years ago

npm install didn't work out-of-the-box, notably on Windows machines with no git installed. Changing the gulp dependency from github in package.json to a regular one fixes the issue.

And while git should be present in every developer's toolbox, there isn't much of a reason to fetch gulp from github rather than the npm repository. Plus, setting up git on Windows is a bit more of a hassle on Windows machines. Hence, I'm making this PR. Hopefully this saves someone some time.

garretthyder commented 4 years ago

Thanks @mziab glad to hear NPM has caught up with its Gulp version. For reference, the source was changed to github due to 4.0 not having been available in NPM at the time. Details - https://github.com/JeremyEnglert/JointsWP/issues/369#issuecomment-432028413

This looks good to me but will leave the merge to @JeremyEnglert so he can do some additional testing.