Open tandrewbarber opened 4 years ago
MemesMafiaAdmin
commented
3 years ago The problem like this was being hit to me, my logo was not rendering on mobile (AMP) version. I do a little research and fond that there could be the following reasons.
I give a deep look over each of the above mentioned point for my site ThemesJar, and it really went smooth.
garretthyder
commented
3 years ago Hello @tandrewbarber,
Hope you found a solution for your issue, didn't notice this one came in.
Taking a quick look at the codebase the theme enables Custom Logo support, but never implements it's use.
For your implementation sounds like you just need to update this line in the parts/nav-offcanvas-topbar.php template partial; https://github.com/JeremyEnglert/JointsWP/blob/master/parts/nav-offcanvas-topbar.php#L12
Then follow these instructions for how to display the Custom Logo in your theme. https://developer.wordpress.org/themes/functionality/custom-logo/#displaying-the-custom-logo-in-your-theme
@JeremyEnglert - Should Custom Logo support be removed since it's not fully implemented? Or should the logo just be conditionally implemented?
When I attempt to customize my theme and insert a site logo, it never appears. It shows up in the small left-hand window when I add it from my media gallery, but then never renders on the website itself. Only in the little area where it says "Remove" or "Change Logo". I have tried several different images or several different sizes and formats... nothing. A similar thing happens if I try to add an image as a featured image on a page. I can insert an image, directly, into the body of a page and it will render fine. Additionally, if I switch to a different theme and insert the very same image, it shows up just fine.
I would really like to stick with this theme, as I like the slim nature of Foundation. As such, I'm happy to troubleshoot/modify anything needed.