search

JeremyGelb / spNetwork

An R package to perform spatial analysis on networks.
GNU General Public License v2.0
34 stars 2 forks source link

Remove compiled object files from src directory #9

Closed mpadge closed 1 year ago

mpadge commented 1 year ago

Hi @JeremyGelb, I was checking out your package to help inform upcoming standards for network software as part of rOpenSci's project for peer review of statistical software, and noticed you've got a bunch of files in your src directory which should be .gitignored. You shouldn't commit .o or .dll files - just add these patterns to .gitignore to stop this happening in the future. Removing these will considerably reduce the size of the repo for anybody cloning it. Thanks!

Also: Great work on putting together this fantastic package. Lots of your routines provide nice enhancements to the kinds of stuff in my dodgr package. Very nice!

JeremyGelb commented 1 year ago

Hi @mpadge ! Thank you for the suggestion ! I just added the patterns to the gitignore file. it will be updated soon on github (I am working on an issue currently). Thank you very much for your interest in spNetwork !

JeremyGelb commented 1 year ago

done !