JeremyGrosser / tablesnap

Uses inotify to monitor Cassandra SSTables and upload them to S3
BSD 2-Clause "Simplified" License
181 stars 86 forks source link

Removes all old jkeys #52

Closed firepub-pfreeman closed 7 years ago

firepub-pfreeman commented 9 years ago

I made an incorrect assumption with the "keep existing" feature. jkeys should not be kept if a file in the key exists. All old jkeys should be deleted to honor the max_age flag. However there are times when that would mean that all listdir.json files are deleted, making it impossible to restore without manually creating the file. So the compromise when using the "keep existing" feature is to always keep at least one jkey (listdir.json file).

JeremyGrosser commented 7 years ago

I believe this was fixed in another PR quite a while ago.