JeremyGrosser / tablesnap

Uses inotify to monitor Cassandra SSTables and upload them to S3
BSD 2-Clause "Simplified" License
181 stars 86 forks source link

tablesnap allows a custom path separator, but tableslurp assumes ':' #69

Open devmage opened 8 years ago

devmage commented 8 years ago

Compare https://github.com/JeremyGrosser/tablesnap/blob/master/tableslurp#L85 and https://github.com/JeremyGrosser/tablesnap/blob/master/tablesnap#L459 .

Tablesnap's interface allows a user to configure a custom path separator, defaulting to : but configurable also with arbitrary separators or '' to achieve no separator.

Tableslurp assumes the use of specifically a : separator, and so is incompatible with any implementation of Tablesnap that uses a custom keyname separator.

katrielt commented 8 years ago

So does tablechop - https://github.com/JeremyGrosser/tablesnap/blob/master/tablechop#L45