JeremyGrosser / tablesnap

Uses inotify to monitor Cassandra SSTables and upload them to S3
BSD 2-Clause "Simplified" License
181 stars 86 forks source link

tablechop don't list deleted files with -l, --list-deletes #74

Closed Mortinke closed 6 years ago

Mortinke commented 7 years ago

tablechop only outputs the number of deleted files and not which files has been deleted.

tablechop -l --aws-region <aws_region> <bucket_name> <keyspace_path> 1
tablechop [2017-02-16 11:53:43,703] INFO Connected to S3, getting keys ...
tablechop [2017-02-16 11:53:43,752] INFO Found 2 index files and 16 data files
tablechop [2017-02-16 11:53:43,754] INFO Keeping 1/2 index files
tablechop [2017-02-16 11:53:43,950] INFO Keeping 16/16 data files
tablechop [2017-02-16 11:53:43,950] INFO Deleting 1/18 files

I get the same output with --list-deletes

tablechop --list-deletes --aws-region <aws_region> <bucket_name> <keyspace_path> 1
tablechop [2017-02-16 11:50:55,010] INFO Connected to S3, getting keys ...
tablechop [2017-02-16 11:50:55,094] INFO Found 6 index files and 62 data files
tablechop [2017-02-16 11:50:55,096] INFO Keeping 5/6 index files
tablechop [2017-02-16 11:50:55,424] INFO Keeping 40/62 data files
tablechop [2017-02-16 11:50:55,424] INFO Deleting 25/68 files
JeremyGrosser commented 7 years ago

Please test the attached PR. I will merge once you've confirmed it works for you.

Mortinke commented 7 years ago

Hi @JeremyGrosser,

thanks for PR. I will test it next week.