fix padding of the elements on the drawer menu

JeremyPP / Android.me-APP

Android app development for ndroidme.com

0 stars 1 forks source link

fix padding of the elements on the drawer menu #13

Closed MohHeader closed 10 years ago

MohHeader commented 10 years ago

@JeremyPP , Screenshots please. :+1:

JeremyPP commented 10 years ago

@MohHeader Ideally, the drawer should look like that (but with the "about" section): https://www.dropbox.com/s/w5yddps5yx4ohw3/home_menu.png

But currently, it's like that: https://www.dropbox.com/s/ejio2i43m73v5sg/2014-06-03%2016.25.36.png

The padding of the first and last items are not equals at the top and at the bottom. As well as the padding on the left side of the setting icon. Speaking of the setting icon, if you could change the current one for this one, it will be great: https://www.dropbox.com/s/7v5tciwhchb1xdc/ic_gear_40.png

MohHeader commented 10 years ago

@JeremyPP , I am not sure if I am close enough, Please check.

JeremyPP commented 10 years ago

@MohHeader Sorry, but I'm having some troubles with Eclipse right now. Can you send me the .apk?

MohHeader commented 10 years ago

Date: Sun, 8 Jun 2014 12:47:29 -0700 From: notifications@github.com To: Android.me-APP@noreply.github.com CC: mohheader@hotmail.com Subject: Re: [Android.me-APP] fix padding of the elements on the drawer menu (#13)

@MohHeader

Sorry, but I'm having some troubles with Eclipse right now.

Can you send me the .apk?

— Reply to this email directly or view it on GitHub.

JeremyPP commented 10 years ago

@MohHeader I think that an error has occurred, your message is empty.

MohHeader commented 10 years ago

@JeremyPP I am Downloading KitKat SDK now, to test it local But I think it had been solved by the last commit,

JeremyPP commented 10 years ago

@MohHeader Sorry about that, but can you send me the .apk again? I still have a problem with this project on eclipse, and I really don't know what is happening.

JeremyPP commented 10 years ago

It seems a lot better now. There's just another little detail to fix. The last item is bigger than the others: https://www.dropbox.com/s/ybcsg2kkbklzl9y/menu.png

Also, if you could change the setting icon for this one: https://www.dropbox.com/s/7v5tciwhchb1xdc/ic_gear_40.png

MohHeader commented 10 years ago

@JeremyPP Done,

Please Provide the Gear Photo with all sizes, Refer to : Android.me-APP/App/AndroidMeFeed/res/drawable-mdpi/ic_settings.png Android.me-APP/App/AndroidMeFeed/res/drawable-hdpi/ic_settings.png Android.me-APP/App/AndroidMeFeed/res/drawable-xhdpi/ic_settings.png Android.me-APP/App/AndroidMeFeed/res/drawable-xxhdpi/ic_settings.png

Also it will be great if you can just change them, & Commit & push to Git repo. :)

Thanks,

JeremyPP commented 10 years ago

For the setting icon, I think that it will stay this way for now. This because I don't have the other sizes. Which is very strange because I got the icon from the Play Store .apk, but there was only this size.