search

Jericho / StrongGrid

Strongly typed library for the entire SendGrid v3 API, including webhooks
182 stars 38 forks source link

TLS is applicable for all events #248

Closed KoditkarVedant closed 4 years ago

KoditkarVedant commented 6 years ago

According to docs TLS can be returned for all events not just Delivery Events. At least they did not specify it is only related to Delivery Events.

Jericho commented 6 years ago

What's strange is that the chart does not have any 'X' in any of the column for the tls property. Is that a mistake in the documentation? I'll open an issue in the SendGrid repo to get clarification.

Jericho commented 6 years ago

I asked for clarification: https://github.com/sendgrid/sendgrid-csharp/issues/792

KoditkarVedant commented 6 years ago

I Just come up with this resolution on the basis of unique_args, marketing_campaign_id, and marketing_campaign_name fields as you can see they did no put X in any column as they were available in all events This is now not true as they have recently added X for all events (earlier they didn't have smpt-id for open and close events). Now it require clarification from them what pattern they use in the chart.

Jericho commented 4 years ago

A year and a half after we reported these inconsistencies, the documentation has finally been updated (here and here)!

Publishing an update shortly with several changes to webhook model C# classes to match the newly updated documentation. Let's hope that their updated documentation is accurate!!!

Jericho commented 4 years ago

:tada: This issue has been resolved in version 0.66.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: