Jericho / ZoomNet

.NET client library for the Zoom.us REST API v2
MIT License
68 stars 48 forks source link

ParticipantDevice Enum #168

Closed birdbm closed 2 years ago

birdbm commented 2 years ago

Good Morning,

While attempting to process more webinars today I ran across another enumeration issue:

image

This causes GetWebinarParticipantsAsync to fail.

birdbm commented 2 years ago

As a small update, I wrapped the call in a try/catch and looped through all other webinars and didn't see any other issues related to that endpoint.

Jericho commented 2 years ago

I double checked the documentation and they don't mentioned "Unknown" as a possible device, but that's easy for me to add to ZoomNet.

What's more intriguing is the fact that, if I understand your scenario correctly, a participant can use more than one device (in the example you presented, the participant used "Unknown" and "Phone", separated by the "+" sign). I need to think about how I'm going to model this in ZoomNet and how I'm going to parse this string into an enum.

Jericho commented 2 years ago

@birdbm Can you share the JSON you get from SendGrid? That would help me write unit tests to ensure we properly parse the "device".

birdbm commented 2 years ago

I'm not sure what SendGrid is, but I have Postman set up and can easily provide the JSON response for that one.
"device": "Unknown + Phone"

Jericho commented 2 years ago

I meant "Zoom", sorry for the confusion (SendGrid is related to another project I maintain).

Do you have a sense for what this value mean? My best guess is that it means the participant joined a webinar with an unknown device (like a computer, for example) for the video part of a webinar and also used a phone to join the audio part. Does that make sense?

birdbm commented 2 years ago

What you said makes sense, but to be honest I'm really not sure exactly what it means. The integration we are building is actually for one of our customers so I'm not familiar enough with the underlying data to be able to confirm that suspicion. I'm curious about whether or not there are other combinations that could be sent if that were the case though.

Jericho commented 2 years ago

Published a beta to my MyGet feed: https://www.myget.org/feed/jericho/package/nuget/ZoomNet/0.39.0-multiple-devices0018

What changed:

birdbm commented 2 years ago

@Jericho that actually broke the strictly 'Unknown' response.

image

Jericho commented 2 years ago

New beta to parse single devices as well as multiple devices: https://www.myget.org/feed/jericho/package/nuget/ZoomNet/0.39.0-multiple-devices0020

By the way, I noticed that the sample in the documentation uses a device called "WIN" which is not a valid value as far as I understand the docs:

image

I'm hoping it's just a typo and "Windows" is the intended sample device.

birdbm commented 2 years ago

@Jericho I'm no longer seeing errors from that endpoint. Thank you so much for the quick turnaround on these!

Jericho commented 2 years ago

Publishing 0.39.0 to NuGet as we speak. Should be available within the next 30 minutes or so.

Jericho commented 2 years ago

:tada: This issue has been resolved in version 0.39.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: