Jericho / ZoomNet

.NET client library for the Zoom.us REST API v2
MIT License
68 stars 48 forks source link

Add `Type` to Recoding model class #298

Closed Jericho closed 1 year ago

synesthesia commented 1 year ago

From the documentation for API event for recording.completed:

type is integer with following possible values:

If the recording is of a meeting:

1 — Instant meeting. 2 — Scheduled meeting. 3 — A recurring meeting with no fixed time. 4 — A meeting created via PMI (Personal Meeting ID). 7 — A Personal Audio Conference (PAC). 8 - Recurring meeting with a fixed time.

If the recording is of a webinar:

5 — A webinar. 6 — A recurring webinar without a fixed time. 9 — A recurring webinar with a fixed time.

If the recording is not from a meeting or webinar:

99 — A recording uploaded via the Recordings interface on the Zoom Web Portal.

Jericho commented 1 year ago

As discussed in a PR recently submitted by @synesthesia, ZoomNet already contains an enum called RecordingType which is used to indicate whether a file is saved locally or in the cloud. Therefore it should have been name something like "RecordingSaveLocation".

Jericho commented 1 year ago

More specifically, the existing type is used when configuring meeting (or webinar) settings. When you are configuring these settings, you have the ability to indicate whether the meeting is automatically recorded and if so, where the recording is saved (either in the cloud or local).

Therefore I think RecordingAutoSaveType is a better name. Naming is hard... :pensive: Suggestions are welcome!

Jericho commented 1 year ago

How about just AutoRecordingType?

Jericho commented 1 year ago

:tada: This issue has been resolved in version 0.64.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: