Adjusting lookup to validate that total records is greater than zero …

Jericho / ZoomNet

.NET client library for the Zoom.us REST API v2

MIT License

69 stars 45 forks source link

Adjusting lookup to validate that total records is greater than zero … #308

Closed joshrogers-pg closed 12 months ago

joshrogers-pg commented 12 months ago

Adjusting lookup to validate that total records is greater than zero before throwing an exception on the property

Issue #307

Jericho commented 12 months ago

Please rebase your fork. I added 6 new unit tests:

3 of them to verify that we throw an exception when records are missing from payload and total_records is greater than zero. This is currently working as excepted and therefore these three tests are successful.
3 of them to verify that we do not throw an exception when records are missing from payload and total_records is zero. These three tests currently fail due to the bug you discovered. Your PR should fix these tests.

joshrogers-pg commented 12 months ago

@Jericho I'll take care of that shortly and push those changes.

joshrogers-pg commented 12 months ago

Thank you @Jericho for responding so quickly and adding those tests. It is much appreciated.

joshrogers-pg commented 12 months ago

@Jericho just a heads up that when you merged the commit for 0.65.0 against main seems to have failed, a CodeCov issue maybe, and thus the package isn't showing up with the latest version.

Jericho commented 12 months ago

For one reason or another, uploading the coverage info to codecov fails quite regularly. I would love to get rid of it but I like their interface. Coveralls on the other hand has a flawless upload process but their UI is sad.

I'll re-trigger the build and cross my fingers that uploading to coveralls will go through as expected.