Jericho / ZoomNet

.NET client library for the Zoom.us REST API v2
MIT License
69 stars 45 forks source link

Bug in Registrant model class with Zoom Meeting API #325

Closed xantari closed 7 months ago

xantari commented 7 months ago

The Registrant.CreatedOn property is never getting populated.

According to Zoom API documentation the property is "create_time" as indicated here: https://developers.zoom.us/docs/api/rest/reference/zoom-api/methods/#operation/meetingRegistrants

This value is always getting returned as "01/01/0001 12:00:00"

I noticed the source code here: https://github.com/Jericho/ZoomNet/blob/c9155ead414174bc97de7759151bc46dc8be26d1/Source/ZoomNet/Models/Registrant.cs#L133

This line of code is wrong:

        /// <summary>
        /// Gets or sets the date and time when the registrant was created.
        /// </summary>
        /// <value>The registrant created time.</value>
        [JsonPropertyName("created_time")]
        public DateTime CreatedOn { get; set; }

It sound be corrected to "create_time" instead of "created_time":

Correct version:

        /// <summary>
        /// Gets or sets the date and time when the registrant was created.
        /// </summary>
        /// <value>The registrant created time.</value>
        [JsonPropertyName("create_time")]
        public DateTime CreatedOn { get; set; }
Jericho commented 7 months ago

Thank you for reporting this issue.

Jericho commented 7 months ago

:tada: This issue has been resolved in version 0.69.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: