Jericho / ZoomNet

.NET client library for the Zoom.us REST API v2
MIT License
69 stars 45 forks source link

Site information returned from Phone endpoints may have changed #345

Open Jericho opened 2 months ago

Jericho commented 2 months ago

@joshrogers-pg Can you help investigating this situation? You submitted a PR back in January to add the ability to retrieve a phone call user profile and you even included a unit test to ensure we properly deserialize a sample JSON. The JSON you included clearly shows that "site_id" is a node in the JSON document. However, @snega1003 recently pointed out that documentation says something different. Evidently, they say that site id and name are grouped inside of a "site" json node. Can you help double check if the way you modeled the user profile (particularly the site information) is still accurate?

If it turns out that the way you model the data is still accurate, that will indicate that there's discrepancy how data is modeled between these two calls and @snega1003 should create his own model class.

joshrogers-pg commented 2 months ago

@Jericho @snega1003

I would have to verify locally, but this is running in production for us and we haven't been getting any serialization errors, so I'd imagine this is a discrepancy in the Zoom models. According to the documentation for the endpoint I implemented, retrieving the profile, the site_id is just a single node: https://developers.zoom.us/docs/api/rest/reference/phone/methods/#operation/phoneUser image

However, when you get a list of users as @snega1003 is doing, the site is an object: https://developers.zoom.us/docs/api/rest/reference/phone/methods/#operation/listPhoneUsers image

I would recommend creating his own model class. If you need me to verify beyond this, please let me know, there will be some turnaround time to that ask, but I'm happy to assist.

Jericho commented 2 months ago

If you don't mind, it would helpful if you could double-check