search

JerloPH / HomeCinema

Organize your local collection of Movies and TV Shows
Other
17 stars 0 forks source link

[BUG] There are double apostrophes ('') in the titles where there should be one ('). #11

Closed zumbawumba closed 3 years ago

zumbawumba commented 3 years ago

Every video file that has an apostrophe in the title, like this:

Mister Magoo's Christmas Carol

Is being indexed in HomeCinema with double apostrophes, like this:

Mister Magoo"s Christmas Carol

Perhaps this is a bug on my end, but all my other software checks fine, and I've never seen such a thing before.

I hope you can duplicate it and fix it. If you need more help/info let me know.

<<<<<<<<<<<<<<<<<<

double apostrophes bug

<<<<<<<<<<<<<<<<<<

Windows 10 64 bit (updated) with North American English keyboard setting

HomeCinema v0.7.1.0 r38

JerloPH commented 3 years ago

Check the 'name' column on 'info' table on your HomeCinema.db file (You can use SQLite DB Browser). If its the same as above screenshot, I might have missed something on saving to database.

EDIT: Made change to dev branch that could possibly fix the issue. I'll create a pre-release build file so make sure to try it. EDIT 2: Link to pre-release: https://github.com/JerloPH/HomeCinema/releases/tag/alpha-v0.7.1.1

zumbawumba commented 3 years ago

I checked with DB Browser for SQLite and the name was the same in HomeCinemaDB.

I then tried your pre-release alpha-v0.7.1.1 and that appears to have fixed the issue.

I'll continue to test HomeCinemaDB and report back as need be.

JerloPH commented 3 years ago

Thanks for the feedback!

My theory on that is I've used a method to sanitize the entries so it can be properly inserted into the database. Apostrophe must be doubled in SQL. In the 'dev' branch, I changed this to sanitize only during the insert query. Instead of during the load up screen.

And thanks for rigorously testing. Much appreciated ☺️

zumbawumba commented 3 years ago

I changed this to sanitize only during the insert query.

Sounds good. Furthermore FYI, this appears to have fixed another related issue, where an apostrophe was being removed, like this:

Original filename: Bob's Fat Cat

Shows up in HC as: Bobs Fat Cat

Regardless, I just tested for that issue again, and all seems to be fine now.

thanks

JerloPH commented 3 years ago

Fixed on dev, not on stable release yet

JerloPH commented 3 years ago

Released fix on v0.7.2