search

Jermolene / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.78k stars 1.16k forks source link

Fix/lingo germany #8269

Closed linonetwo closed 1 week ago

linonetwo commented 1 week ago

fixes #8263 fixes #8262 @pmario

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Jun 17, 2024 5:29pm
pmario commented 1 week ago

I can create a dependency tree, that will fall back to English instead of German, which technically would be wrong. -- But -- There is a fallback now.

The dependency tree mentioned above is "constructed to fail". It's not very likely to be a real world configuration.

pmario commented 1 week ago

@Jermolene -- This is a fix, that needs to go into v5.3.4, since it would be a general regression.

This PR is related to: menu-bar German translation first take #8264

linonetwo commented 1 week ago

I will write a JS version later. I was also afraid that so many transluction widget will be slow.

pmario commented 1 week ago

hmmm, I do not really see a performance problem, for UI elements, which most of the translations are.

"Inner" transclusions are only executed, if they do not return anything. So the transclusion-widget returns early.

All the filters strings are "compiled" into js-functions and cached internally.

I will write a JS version later.

What will be the advantage of a JS version?

Edit: OK I did see the conversation starting at: https://github.com/Jermolene/TiddlyWiki5/pull/7821#issuecomment-2176843674 --- So forget about that question