Jermolene / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.78k stars 1.16k forks source link

Improve ControlPanel Settings style-ability #8275

Closed pmario closed 1 week ago

pmario commented 1 week ago

This PR improves the ControlPanel Settings style-ability as requested by @twMat at https://github.com/Jermolene/TiddlyWiki5/pull/8000#issuecomment-2178307290

Quote from Mat,

I do note that each setting still has the inline style="border-top:1px solid #eee;" (which makes it impossible to override with a custom stylesheet) so I'm wondering if this should perhaps be moved into the introduced class="tc-control-panel-setting" ?

I did use the palette colour for blockquote-bar, because it is a good fit with all existing palettes.

Blockquote bars are usually placed into the tiddler content area and they have a contrast, that is not "intrusive". That's exactly the behaviour we need for a setting separator

This PR is related to the PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Jun 19, 2024 4:22pm
pmario commented 1 week ago

@Jermolene -- This PR is a fix for PR #8000 which is part of TW v5.3.4 -- So IMO this one should be considered as a "bug fix" and should go into v5.3.4

Jermolene commented 1 week ago

Thanks @pmario