Testcase UI enhancements

Jermolene / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.

https://tiddlywiki.com/

Other

7.78k stars 1.16k forks source link

Testcase UI enhancements #8292

Closed Jermolene closed 2 days ago

Jermolene commented 3 days ago

Building on #8290, this PR improves the UI of the testcase widget:

Button to copy the text of any of the payload tiddlers
Adds dropdown menu to testcase toolbar
Option to export payload tiddlers as a file
Option to import payload tiddlers into the main wiki (giving the user a chance to rename them)
Lightens the background colour

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
tiddlywiki5	✅ Ready (Inspect)	Visit Preview	Jun 26, 2024 9:26am

Jermolene commented 3 days ago

Do we think this is worth merging before v5.3.4? @pmario @saqimtiaz @btheado

pmario commented 3 days ago

I like, that it now also shows the ExpectedResult tiddler in the tabs.
- We should definitely keep that one.
The import dropdown is nice, so the content of the test can be extracted easily and users can "play" with it in the "real" wiki.

All in all I think it's a good start and imo it's worth to be merged. So we can get more user feedback once it is released.

I think there is potential for much more ... but that's for the time after the v5.3.4 release.

Jermolene commented 3 days ago

Thanks @pmario.

The other thing I wondered about was a means to drag and drop the payload tiddlers out of the testcase. One possibility might be to explore making the tabs for individual tiddlers be draggable. Perhaps we'd also want to make it possible to drag all the payload tiddlers at once, like a tag pill.

btheado commented 3 days ago

I think these are great improvements and very worthwhile to merge for 5.3.4

Jermolene commented 3 days ago

I do agree that it would be good to merge this for v5.3.4. If we are going to do so, it would be very helpful to have some more testing of the modifications to the handlers of the tm-save-wiki and tm-download-file.

Jermolene commented 2 days ago

Thank you everyone, I've made some very minor style tweaks and will now merge this.