search

Jermolene / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.79k stars 1.16k forks source link

[BUG] Save button does not turn red for Solarized* palettes #8334

Open twMat opened 4 days ago

twMat commented 4 days ago

[Edit: It turns out @Leilei332 posted PR #8329 which would solve this!]

Describe the bug

Using either of themes "SolarizedDark" and SolarizedLight, the Save button colour remains unaffected (not turning red) even when wiki is dirty.

Also, but of less importance IMO: Using Vanilla, the Controlpanel button darkens somewhat when the Controlpanel tiddler is open. All good. But this does not happen for some of the other palettes... - Or maybe it does and my eyes are just too weak? Or maybe this is a feature, just like the Create new tiddler-button is colored for only some palettes?

Expected behavior

The Save button should have starkly contrasting state colours in every palette.

To Reproduce

  1. Go to tiddlywiki.com and open Controlpanel to Palettes
  2. Switch around and observe the page buttons

Screenshots

image

TiddlyWiki Configuration

...

Additional context

No response

pmario commented 4 days ago

All the palettes will need some attention. There are several problems in all of them.

The dirty-indicator for the solarized themes has inherit as value, which is wrong.

Leilei332 commented 4 days ago

I have made a pull request which can solve your problem: #8329

This pull request was originally intended for fixing the transparent draft list when using the Solarized palettes. Since it changed the value of dirty-indicator to a red color, it can also solve this.

twMat commented 4 days ago

@Leilei332 - oh, even just yesterday, that's certainly a coincidence! I'll close this issue if yours is merged. And I'll edit this OP to mention yours. Thanks for your PR.