search

Jeroen-G / autowire

🔌 Autowire and configure using PHP 8 Attributes in Laravel.
MIT License
21 stars 3 forks source link

Add option to use custom attribute classes #5

Closed bitwise-operators closed 2 years ago

bitwise-operators commented 2 years ago

This change allows users to create custom attribute classes, implementing the interface supplied by the package, and use those to mark their interfaces and/or classes.

Jeroen-G commented 2 years ago

Thank you for your contribution!

bitwise-operators commented 2 years ago

You're quite welcome!

Just to be sure: I did update the readme, but not the version number, and added it to the 'upcoming features' in the changelog.

So right now the readme is already listing this feature, but unless people specify the dev-main branch in composer, the code does not match the manual.

I also noticed that the codestyle-checker in de CI pipeline is not entirely satisfied (I placed a private method before a public method).

Do you want me to fix these issues with another PR?

Jeroen-G commented 2 years ago

Sure! I wanted to check why it didn't fail on the PR but only on main, I think there is something wrong in the github actions workflow.

You should be able to run the fixer locally so you don't have to make the changes manually.