search

Jeroen-G / autowire

🔌 Autowire and configure using PHP 8 Attributes in Laravel.
MIT License
21 stars 3 forks source link

Fix codestyle issue and changelog #6

Closed bitwise-operators closed 2 years ago

bitwise-operators commented 2 years ago

style: move private method to correct position docs: moved new feature to 1.4.0 header in changelog

With this, it should be safe to publish and release a new '1.4.0' tag to trigger Packagist.

Thanks!

Jeroen-G commented 2 years ago

Could you help out and in ci.yml change 

on: 
    push:

to 

on: 
    push:
    pull_request:

so codestyle checks are run in pull requests again. 🙏

bitwise-operators commented 2 years ago

Done.

Fixing that also revealed that there was insufficient test coverage on the constructor of Electrician, so I added two extra tests for that, and changed it over to a custom Exception instead of Webmozart\Assert.

Jeroen-G commented 2 years ago

Sweet!

Jeroen-G commented 2 years ago

Tagged 1.4.0