Jeroen-G / laravel-photo-gallery

A photo gallery for Laravel
40 stars 32 forks source link

Laravel 4.1 #1

Closed cybertek closed 10 years ago

cybertek commented 10 years ago

Great Job, but does not work with current version of Laravel 4 - version 4.1.x.

Is there an expected update for this release?

Jeroen-G commented 10 years ago

I haven't tried this with L4.1, could you tell what doesn't work? It is on my todo list to update the package! It will only take some time. :(

AlexRegenbogen commented 10 years ago

I think Cybertek is referring to the issue which comes up when running composer update on L4.1: My output:

Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Conclusion: remove laravel/framework 4.1.x-dev
    - Conclusion: don't install laravel/framework 4.1.x-dev
    - Conclusion: don't install laravel/framework v4.1.18
    - Conclusion: don't install laravel/framework v4.1.17
    - Conclusion: don't install laravel/framework v4.1.16
    - Conclusion: don't install laravel/framework v4.1.15
    - Conclusion: don't install laravel/framework v4.1.14
    - Conclusion: don't install laravel/framework v4.1.13
    - Conclusion: don't install laravel/framework v4.1.12
    - Conclusion: don't install laravel/framework v4.1.11
    - Conclusion: don't install laravel/framework v4.1.10
    - Conclusion: don't install laravel/framework v4.1.9
    - Conclusion: don't install laravel/framework v4.1.8
    - Conclusion: don't install laravel/framework v4.1.7
    - Conclusion: don't install laravel/framework v4.1.6
    - Conclusion: don't install laravel/framework v4.1.5
    - Conclusion: don't install laravel/framework v4.1.4
    - Conclusion: don't install laravel/framework v4.1.3
    - Installation request for jeroen-g/laravel-photo-gallery v1.0 -> satisfiable by jeroen-g/laravel-photo-gallery[v1.0].
    - Conclusion: don't install laravel/framework v4.1.2
    - Conclusion: don't install laravel/framework v4.1.1
    - jeroen-g/laravel-photo-gallery v1.0 requires illuminate/support 4.0.x -> satisfiable by laravel/framework[4.0.x-dev, v4.0.0, v4.0.0-BETA2, v4.0.0-BETA3, v4.0.0-BETA4, v4.0.1, v4.0.10, v4.0.2, v4.0.3, v4.0.4, v4.0.5, v4.0.6, v4.0.7, v4.0.8, v4.0.9], illuminate/support[4.0.x-dev, v4.0.0, v4.0.0-BETA2, v4.0.0-BETA3, v4.0.0-BETA4, v4.0.1, v4.0.10, v4.0.2, v4.0.3, v4.0.4, v4.0.5, v4.0.6, v4.0.7, v4.0.8, v4.0.9].
    - Can only install one of: laravel/framework[v4.1.0, 4.0.x-dev].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.0].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.0-BETA2].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.0-BETA3].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.0-BETA4].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.1].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.10].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.2].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.3].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.4].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.5].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.6].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.7].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.8].
    - Can only install one of: laravel/framework[v4.1.0, v4.0.9].
    - don't install illuminate/support 4.0.x-dev|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.0|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.0-BETA2|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.0-BETA3|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.0-BETA4|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.1|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.10|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.2|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.3|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.4|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.5|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.6|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.7|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.8|don't install laravel/framework v4.1.0
    - don't install illuminate/support v4.0.9|don't install laravel/framework v4.1.0
    - Installation request for laravel/framework 4.1.* -> satisfiable by laravel/framework[4.1.x-dev, v4.1.0, v4.1.1, v4.1.10, v4.1.11, v4.1.12, v4.1.13, v4.1.14, v4.1.15, v4.1.16, v4.1.17, v4.1.18, v4.1.2, v4.1.3, v4.1.4, v4.1.5, v4.1.6, v4.1.7, v4.1.8, v4.1.9].
Jeroen-G commented 10 years ago

That's most likely because the composer.json of this package states: "illuminate/support": "4.0.x" as a requirement. If you change it to 4.1.x it'll probably work. I will test this myself this weekend and update the package if it solves the problem.

A bit off-topic: do you have any suggestions for improvement of the package? Because I don't really know if people are using it and so if I should continue to work on it.

AlexRegenbogen commented 10 years ago

That would make sense... didn't look that far, and instead checked out the repo for the 'Welpen' which had the gallery inside as well... I'm toying around with it at the moment, and will probably try to implement this in a little side-project I'm doing at the moment. (overhaul of an ancient Joomla site, which only needs a few pages and a couple of galleries) I'll see what I can come up with in the range of improvements! :-)

I'm thinking of adding in:

If I think of other stuff, I won't hesitate to let you know!

Thanks for the time I've saved already by using this! :+1:

Jeroen-G commented 10 years ago

Done. See the new 1.1 release; https://github.com/Jeroen-G/laravel-photo-gallery/releases/tag/v1.1